Thanks, Jesse!
-
Best regards, Vladimir
On 11/25/16, 10:03, "Jesse" <purplecabb...@gmail.com> wrote:
Sorry for the late reply, missed this email in the spam folder.
These changes look great, thanks!
Cheers,
Jesse
@purplecabbage
risingj.com
On Thu, Nov 17, 2016 at 6:30 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:
> Hey all
>
> Just FUI, we're done some refactoring that aims to move some
> windows-specific logic (in particular, applying <config-file> changes to
> appxmanifests files) out of cordova-common into cordova-windows. I hope
> this would simplify maintenance of both cordova-common and cordova-windows
> in future
>
> Just in case if anyone is interested, here is the PR that these windows
> bits from cordova-common:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2F&data=02%7C01%7Cv-vlkoti%40microsoft.com%7C4bcd445d56fa455b323e08d415013ec2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636156542464256661&sdata=3UYboUT79uLFzFHgzGUKtyw%2BYK581wdUwMAbjCRdNNI%3D&reserved=0
> cordova-lib/pull/505/files, and this PR adds them to cordova-windows:
>
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-windows%2Fpull%2F207&data=02%7C01%7Cv-vlkoti%40microsoft.com%7C4bcd445d56fa455b323e08d415013ec2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636156542464256661&sdata=qY8A8owzq1ZFKkci14luDlyBchAjPNqxIVzthidmN64%3D&reserved=0.
Note that changes in
> windows are backward compatible, I.e. it will continue to work with
> previous versions of cordova-common, so we don't need to merge them at
once
> and do a release ASAP
>
> I was going to merge this by tomorrow EOD, but if anyone wants to take a
> look - I would appreciate any feedback
> Thanks
>
> -
> Best regards, Vladimir
>
