Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92190238
--- Diff: appium-tests/common/common.spec.js ---
@@ -228,11 +228,18 @@ describe('Contacts Android', function () {
function checkSession(done) {
if (failedToStart) {
fail('Failed to start a session');
- done();
}
+ done();
--- End diff --
Ah, what the hell, you are right! This is bizarre: calling `fail` in a
`beforeEach` _does not prevent the spec from executing_. The spec gets marked
as failed correctly, but it still runs through the entire spec. It seems like
this is a known (and open) issue in Jasmine:
https://github.com/jasmine/jasmine/issues/577
Grrrr, that's annoying. I wanted to clean the test code up by moving the
session check into a `beforeEach` :(. Sigh...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
