Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/510#discussion_r92901030
--- Diff: cordova-lib/spec-plugman/install.spec.js ---
@@ -345,13 +344,14 @@ describe('install', function() {
it('should not check custom engine version that is not supported
for platform', function() {
var spy = spyOn(semver, 'satisfies').and.returnValue(true);
- runs(function() {
- installPromise( install('blackberry10', project,
plugins['com.cordova.engine']) );
- });
- waitsFor(function() { return done; }, 'install promise never
resolved', 200);
- runs(function() {
+ install('blackberry10', project,
plugins['com.cordova.engine']).then(function(done) {
+ expect(false).toBe(true);
+ done();
+ },
+ function err(errMsg) {
expect(spy).not.toHaveBeenCalledWith('','>=3.0.0');
--- End diff --
is this being run? Why call it err and pass errMsg? You don't seem to be
using errMsg
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
