I vote +1

- Verified archive signature
- Verified license headers
- Verified dependencies have appropriate licenses
- Verified ‘cordova serve’ command and browser platform work with the version 
being released

-
Best regards, Vladimir
 

On 12/22/16, 13:07, "Alexander Sorokin (Akvelon)" <v-als...@microsoft.com> 
wrote:

    I vote +1.
    
    * Verified archive with coho
    * Verified tag
    * Ability to install/uninstall Cordova
    * Ability to update Cordova
    * Ability to create blank app for Windows, Android
    * Ability to build/run apps
    * Reviewed release notes
    * Verified version
    * Verified line breaks
    * Verified 'cordova serve'
    * Verified that browserified app builds and runs correctly
    * Ensured --nobuild option works
    
    
    ________________________________
    From: Tim Barham <tim.bar...@microsoft.com>
    Sent: Thursday, December 22, 2016 7:24:23 AM
    To: dev@cordova.apache.org
    Subject: [VOTE] cordova-serve 1.0.1 release
    
    Please review and vote on this Tools Release by replying to this email (and 
keep discussion on the DISCUSS thread)
    
    Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-12289&data=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514&sdata=Lt701h2YtQAVLUhXv6kqLK2FH5E0X3i245dEIcBGQPk%3D&reserved=0
    
    The release has been published to dist/dev: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fcordova%2FCB-12289%2F&data=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514&sdata=mgEMD%2FAXvtRhefGha89Ca%2F1ShQt%2F0wVRe2avrB6vi80%3D&reserved=0.
 It has also been published to npm with the "rc" tag, and can be installed for 
testing using "cordova-serve@rc"
    
    The packages were published from their corresponding git tags:
    
        cordova-lib: serve-1.0.1 (510a698841)
    
    Upon a successful vote I will upload the archives to dist/, publish them to 
NPM, and post the corresponding blog post.
    
    Voting guidelines: 
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%2Frelease-voting.md&data=02%7C01%7Cv-alsoro%40microsoft.com%7C9688f4a40c104c8857de08d42a2279c1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636179774936024514&sdata=x4H9lVx8d6Q5H%2FSocZjdkHsMu7%2BF0ttejlPH8sVJHbw%3D&reserved=0
    
    Voting will go on for a minimum of 48 hours.
    
    I vote +1:
    
    * Ran coho audit-license-headers over the relevant repos
    * Ran coho check-license to ensure all dependencies and subdependencies 
have Apache-compatible licenses
    * Manually verified package contents
    

Reply via email to