Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/499#discussion_r97894467
  
    --- Diff: cordova-lib/spec-cordova/pkgJson-restore.spec.js ---
    @@ -680,10 +681,10 @@ describe('update config.xml to include platforms in 
pkg.json', function () {
     
             // Expect that config.xml contains only android at this point 
(basePjgJson4)
             expect(configEngArray.indexOf('android')).toBeGreaterThan(-1);
    -        expect(configEngArray.indexOf('ios')).toEqual(-1);
    +        expect(configEngArray.indexOf('browser')).toEqual(-1);
             expect(configEngArray.length === 1);
    -        // Pkg.json has cordova-ios in its dependencies.
    -        expect(pkgJson.dependencies).toEqual({ 'cordova-android' : 
'^3.1.0', 'cordova-ios' : '^4.3.0' });
    +        // Pkg.json has cordova-browser in its dependencies.
    +        expect(pkgJson.dependencies).toEqual({ 'cordova-android' : 
'^3.1.0', 'cordova-browser' : '^4.3.0' });
    --- End diff --
    
    same, need to update browser version


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to