GitHub user cnspaha opened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/11

    CB-12543 (iOS) Set orientation on when locking the device

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Instead of just locking the orientation, it also rotates to it. Mandatory 
for iOS.
    
    ### What testing has been done on this change?
    Manual testing on iOS 10, iPhone 6+.
    Run: "npm test"
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform 
affected.
    - [] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cadenasgmbh/cordova-plugin-screen-orientation 
setOrientationOnLock

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit 7185add951fff8d405338af5ef812cb34c476315
Author: Pascal Häusler <p.haeus...@cadenas.de>
Date:   2017-03-03T14:03:09Z

    Rotate to specified orientation when locked

commit 141dea7e6b28f3900e530dd7e2def21f762e807d
Author: Pascal Häusler <p.haeus...@cadenas.de>
Date:   2017-03-06T06:19:56Z

    Refactor

commit fbe1c98d8c9389dabaef23b5c0b31b015ff87c3b
Author: Pascal Häusler <p.haeus...@cadenas.de>
Date:   2017-03-06T06:26:54Z

    Update screenorientation.js to prevent jshint to fail test

commit 2ee910ecbcd2311d150e32dcdca0aa5d3482ca5f
Author: Pascal Häusler <p.haeus...@cadenas.de>
Date:   2017-03-06T06:27:34Z

    Update CDVOrientationproxy.js to prevent jshint to fail test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to