Github user shazron commented on the issue:

    https://github.com/apache/cordova-plugin-media/pull/131
  
    Please edit the Github PR title as already requested: change `CB-1254` to 
`CB-12542`
    This is so Apache Cordova JIRA can auto-track comments on this PR to the 
correct JIRA issue. Since it did not have the correct title, the activity was 
not tracked correctly, so it was probably missed.
    
    For code review -- this is the only commit that is worth reviewing: 
https://github.com/apache/cordova-plugin-media/pull/131/commits/1bba3cfbdc8bc1ebc053f46af824892d548d0088
    
    The other stray commits are due to your branch being based off something 
other than the master branch ( it has probably diverged somehow) and these 
_will_ end up in the master branch as well if pulled in as-is, and thus will be 
unacceptable. This issue will need to be rectified before this can be pulled in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to