[GitHub] cordova-android issue #370: CB-12595: Fix Android Studio Detection (may need...

[filmaj]

Github user filmaj commented on the issue:

    https://github.com/apache/cordova-android/pull/370
  
    Results of my testing with this.
    
    # Mac
    
    Side-by-side installations of Android Studio + Android Studio Preview:
    
    ```
    ➔ l /Applications/Android*
    /Applications/Android Studio 2.4 Preview.app:
    total 0
    drwxr-xr-x@  3 maj   staff   102B 18 Mar 21:10 .
    drwxrwxr-x+ 69 root  admin   2.3K 22 Mar 18:06 ..
    drwxr-xr-x@ 12 maj   staff   408B 18 Mar 21:16 Contents
    
    /Applications/Android Studio.app:
    total 0
    drwxr-xr-x@  3 maj   admin   102B 24 Feb 19:03 .
    drwxrwxr-x+ 69 root  admin   2.3K 22 Mar 18:06 ..
    drwxr-xr-x@ 12 maj   admin   408B 24 Feb 11:14 Contents```
    
    Running the relevant method directly in node:
    
    ```
    ➔ node
    > cr=require('./templates/cordova/lib/check_reqs')
    > cr.get_gradle_wrapper()
    '/Applications/Android Studio 2.4 
Preview.app/Contents/gradle/gradle-3.4.1/bin/gradle'
    ```
    
    Note that in my environment, `gradle` is not on my `PATH`:
    
    ```
    ➔ which gradle
    gradle not found
    ```
    
    # Windows
    
    I installed the preview beside the existing Android Studio under 
`C:\Program Files\Android`:
    
    ```
    C:\Program Files\Android>dir
    
    03/22/2017  11:26 PM    <DIR>          .
    03/22/2017  11:26 PM    <DIR>          ..
    03/13/2017  06:12 PM    <DIR>          Android Studio
    03/22/2017  08:24 PM    <DIR>          Android Studio Preview
    ```
    
    Running the relevant function in node:
    
    ```
    C:\src\cordova-android\bin>node
    > cr = require('./templates/cordova/lib/check_reqs')
    > cr.get_gradle_wrapper()
    C:\Program Files\Android
    Android Studio
    C:\Program Files\Android\Android Studio\gradle
    ```
    
    `gradle` is also not on the `PATH` in Windows:
    
    ```
    C:\src\cordova-android\bin>where gradle
    INFO: Could not find files for the given pattern(s).
    ```
    
    So, it doesn't pick the preview version, just the regular Android Studio 
version - unlike on Mac. Not sure if that's a showstopper @infil00p. Also worth 
noting the extra output (`console.logs` in this code).
    
    Still setting up my Linux VM so can't report back for that at the moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org