I vote +1: *Ran coho verify-archives against all .tgz dists * All relevant repos are green on http://status.cordova.io
@purplecabbage risingj.com On Mon, May 1, 2017 at 3:43 PM, Shazron <shaz...@gmail.com> wrote: > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * All relevant repos are green on http://status.cordova.io > > On Fri, Apr 28, 2017 at 11:23 AM, Filip Maj <maj....@gmail.com> wrote: > > > Please review and vote on the release of this plugins release by > > replying to this email (and keep discussion on the DISCUSS thread). > > > > Release issue: https://issues.apache.org/jira/browse/CB-12736 > > > > The plugins have been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/CB-12736/ > > > > The packages were published from their corresponding git tags: > > cordova-plugin-battery-status: 1.2.4 (dfec094) > > cordova-plugin-camera: 2.4.1 (ba9a803) > > cordova-plugin-console: 1.0.7 (fa26558) > > cordova-plugin-contacts: 2.3.1 (1c27c9a) > > cordova-plugin-device-motion: 1.2.5 (04ce0ea) > > cordova-plugin-device-orientation: 1.0.7 (7af309f) > > cordova-plugin-device: 1.1.6 (eeb48e8) > > cordova-plugin-dialogs: 1.3.3 (34cccf6) > > cordova-plugin-file: 4.3.3 (06ff0eb) > > cordova-plugin-file-transfer: 1.6.3 (720f314) > > cordova-plugin-geolocation: 2.4.3 (12fae5b) > > cordova-plugin-globalization: 1.0.7 (273e5a6) > > cordova-plugin-inappbrowser: 1.7.1 (ff6a765) > > cordova-plugin-media: 3.0.1 (2a1ee43) > > cordova-plugin-media-capture: 1.4.3 (b78a4b2) > > cordova-plugin-network-information: 1.3.3 (710b53d) > > cordova-plugin-screen-orientation: 20.1 (8699159) > > cordova-plugin-splashscreen: 4.0.3 (85aa605) > > cordova-plugin-statusbar: 2.2.3 (77a6ae5) > > cordova-plugin-vibration: 2.1.5 (96c4ad6) > > cordova-plugin-wkwebview-engine: 1.1.3 (fce6123) > > > > Upon a successful vote I will upload the archives to dist/, upload > > them to npm, and post the corresponding blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/ > release-voting.md > > How to vote on a plugins release at > > https://github.com/apache/cordova-coho/blob/master/docs/ > > plugins-release-process.md#voting > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos (via coho > > prepare-plugins-release) > > * Ran mobile spec on these relevant plugins for both Android and iOS. > > Summary: > > - Android: > > - Created a project w/ cordova-android@6.2.2 and tested on a Google > > Pixel device running Android 7.1.2 > > - One autotest failure: FileAPI resolveLocalFileSystemURL on > > cdvfile:// file.spec.147, got error code 1 > > - Was unable to reproduce the above failure in the File plugin manual > > tests. > > - iOS: > > - Created a project w/ cordova-ios@4.4.0 and tested on an iPhone 5S > > running iOS 10.3.1. > > - A few autotest failures: > > - (same as android): FileAPI resolveLocalFileSystemURL on > > cdvfile:// file.spec.147, got error code 1 > > - filetransfer.spec.8: download file over https, timedout > > - filetransfer.spec.21: able to stop via abort(), timedout > > - media.spec.24: playback rate should be set properly using > > setRate, however, running this multiple times shows it passes > > sometimes and fails other times with errors in the form: > > - 2.9 not to be less than 4 > > - 2.8 not to be less than 4 > > … tells me the test might be a little brittle? > > - media.spec.27: should call success or error when stopping a > > media that is in starting state.expected false to be true. > > * Ensured continuous build was green when repos were tagged. Relevant > > CI links (thank you Alex Sorokin for these!): > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-battery-status-commit/23/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-camera-commit/13/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-console-commit/8/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-contacts-commit/11/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-device-commit/10/ > > - http://cordova-ci.cloudapp.net:8080/view/Pull%20requests/ > > job/cordova-plugin-device-motion-pr/26/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-device-orientation-commit/8/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-dialogs-commit/9/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-file-commit/12/ > > - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin- > > file-transfer-pr/75/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-geolocation-commit/9/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-globalization-commit/11/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-inappbrowser-commit/13/ > > - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/122/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-media-capture-pr/37/ > > - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin- > > network-information-commit/7/ > > - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin- > > screen-orientation-commit/10/ > > - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin- > > splashscreen-pr/48/ > > - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin- > > statusbar-commit/9/ > > - http://cordova-ci.cloudapp.net:8080/view/Per-commit% > > 20testing/job/cordova-plugin-vibration-commit/10/ > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
