GitHub user ZauberNerd opened a pull request: https://github.com/apache/cordova-node-xcode/pull/1
Fix possible null-access error in "removeFromFrameworksPbxGroup" The method `project.removeFromFrameworksPbxGroup` directly tries to access `children` on `project.pbxGroupByName` - but this method might return `null` if no such group exists. To prevent a runtime error when trying to access a property on `null` we can add a check whether the requested group "Frameworks" does exist in the project and only then continue with the removal of the file. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ZauberNerd/cordova-node-xcode fix-removeFromFrameworksPbxGroup Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-node-xcode/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 ---- commit 4dee445feec7dc886b9fd176ab28445e682ae631 Author: ZauberNerd <zaubern...@zaubernerd.de> Date: 2017-05-04T13:24:06Z Fix possible null-access error in "removeFromFrameworksPbxGroup" The method `project.removeFromFrameworksPbxGroup` directly tries to access `children` on `project.pbxGroupByName` - but this method might return `null` if no such group exists. To prevent a runtime error when trying to access a property on `null` we can add a check whether the requested group "Frameworks" does exist in the project and only then continue with the removal of the file. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org