GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/554
CB-12738: Cordova ignores plugin dependency version on windows platform
<!--
Please make sure the checklist boxes are all checked before submitting the
PR. The checklist
is intended as a quick reference, for complete details please see our
Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
windows
### What does this PR do?
Steps to reproduce w\ `cordova-7.0.2-dev`:
1) `cordova create sample`
2) `cordova platform add android`
3) `cordova plugin add cordova-plugin-file-transfer`
`Cordova-plugin-file-transfer` has `cordova-plugin-file@^4.0.0` as
dependency and it should install the latest version (`4.4.3`), but after
installation, I get `4.0.0`. Cordova treats `^` symbol as special in windows
shell when running `npm.cmd install` and ignores it. We should enclose version
range with quotes in case of windows platform.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform
affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-lib
fix-plugin-dependency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/554.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #554
----
commit d0c2bef764856f12cac0f77152ffb022d77ab3e1
Author: Nikita Matrosov <v-nim...@microsoft.com>
Date: 2017-05-10T08:58:51Z
CB-12738: Cordova ignore plugin dependency version on windows platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
