+1 Fail and freak out so everyone knows!
@purplecabbage risingj.com On Fri, Jun 2, 2017 at 10:59 AM, Steven Gill <stevengil...@gmail.com> wrote: > You are right in that we don't fail the build when a incompatible plugin > fails to install. > > cordova-fetch doesn't change this behavior as it is install time vs fetch > time. Also this is a difference between using cordovaDependencies in > package.json vs engine in config.xml. If a CordovaDependencies check fails, > cordova would try to fetch a version that did work. If a engine check > fails, it skips installing it. If cordova users don't read the warning, > they may think the plugin was installed without issue. > > I'm down to change this behavior to fail. > > On Fri, Jun 2, 2017 at 10:15 AM, Shazron <shaz...@gmail.com> wrote: > > > Consensus on this long stewing issue of 7 months? > > > > If you deleted the thread: > > 1. Issue https://issues.apache.org/jira/browse/CB-12122 > > 2. Thread https://s.apache.org/ofqR > > > > +1 on engine check failing the build. > > Questions that need answered: Does cordova-fetch on cordova@7 do this > > already, like Simon said? > > > > > > On Mon, Nov 7, 2016 at 6:34 PM, Simon MacDonald < > simon.macdon...@gmail.com > > > > > wrote: > > > > > I think an engine check should fail the build. If there plugin version > > > they are trying to use will not work with the version of cordova or > > > platform they are currently using in their project it should not > > > build. Folks can screw up their semver in config.xml and end up > > > pulling in a plugin version that doesn't work with the CLI they are > > > currently using so stuff will just be horribly broken without them > > > knowing. > > > > > > Also, I thought the new cordova-fetch was supposed to prevent this > > > sort of thing? > > > Simon Mac Donald > > > http://simonmacdonald.com > > > > > > > > > On Mon, Nov 7, 2016 at 8:24 PM, Shazron <shaz...@gmail.com> wrote: > > > > See https://issues.apache.org/jira/browse/CB-12122 > > > > > > > > Right now if a plugin fails an <engines> check, it just warns. Should > > we > > > > make engine checks fail the build? > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > >
