Github user filmaj commented on the issue:

    https://github.com/apache/cordova-android/pull/386
  
    I think one more tweak would be good:
    
    So by putting `root:true` into the spec/**/ directories' eslintrc files, 
when eslint searches up the directory tree to find an eslintrc file, once it 
finds the file, it'll stop searching further. eslint, however, supports 
"cascading" or combining multiple config files into one. We can leverage this 
to define one project-level eslintrc file in the root of the project dir, but 
then also have additional eslintrc files in project subdirectories if there are 
specific rules we want to apply per-directory.
    
    So I think what we want to do is:
     - have the project-root-directory-level eslintrc file specify `root:true`
     - any subdirectory-level eslintrc files _not_ to specify `root:true`
       - this would then cause eslint to apply the rules from subdirectories, 
but keep going to search for further rules, and in our case, it would keep 
going until it hit the project-root-directory-level eslintrc, apply those 
rules, and because that one has `root:true`, stop there.
     - additionally, in this repo, both the spec/e2e and spec/unit directories 
need just a single additional rule: `env: jasmine: true`. So we could actually 
put a single eslintrc file under `/spec/.eslintrc.yml` and have it contain only 
the one `env: jasmine: true` rule. Since root is not set to true for the 
`spec/.eslintrc.yml` file, it'll go up one more directory and apply the 
project-level eslintrc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to