Github user Giorgioshooter commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/321#discussion_r123258853
  
    --- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m ---
    @@ -79,8 +79,16 @@ - (BOOL)application:(UIApplication*)application 
openURL:(NSURL*)url sourceApplic
             return NO;
         }
     
    +    NSDictionary *openURLData = @{
    +            @"url": url,
    +            @"sourceApplication": sourceApplication,
    +            @"annotation": annotation
    --- End diff --
    
    Good point @pbudzinsky .  I should revert to my original commit where I did 
explicit checks on sourceApplication and annotation then. sourceApplication can 
be nil too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Reply via email to