+1 ran cordova build ios --device --release and validated that the resulting .ipa can be submitted to iTunes Connect
2017-09-08 3:36 GMT+02:00 Audrey So <a...@adobe.com.invalid>: > I vote +1. > > - Ran npm test (Pass) > - Created & deployed app on emulator > - Ran coho audit-license-headers over the relevant repos > - Ran coho check-license to ensure all dependencies and sub dependencies > have Apache-compatible licenses > > > > > On 9/7/17, 2:45 PM, "Suraj Pindoria" <suraj.pindo...@yahoo.com.INVALID> > wrote: > > > I vote +1:* Ran coho audit-license-headers* Ran npm test, all passing* > Created hello world app and deployed to emulator/device > > On Wednesday, September 6, 2017, 2:25:49 AM PDT, Shazron < > shaz...@apache.org> wrote: > > > > Please review and vote on this 4.5.0 iOS Release by replying to this > email > >(and keep discussion on the DISCUSS thread) > > > >Release issue: https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB- > 13247&data=02%7C01%7C%7Cdc0ae31e6f184ea4b6cc08d4f63b1d05% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636404181131226937&sdata= > xGmzqKw0JF298rQf4Tw%2BvQ9WJMw8czUjsTB%2B4aNIeHo%3D&reserved=0 > > > >The archive has been published to dist/dev: > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev% > 2Fcordova%2FCB-13247&data=02%7C01%7C%7Cdc0ae31e6f184ea4b6cc08d4f63b1d05% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636404181131226937&sdata= > Nydm2eV9yGbIXh%2BQQIvTq3yU1JNUolRoE%2Bz7B4sUc28%3D&reserved=0 > > > >The package was published from its corresponding git tag: > > cordova-ios: 4.5.0 (7f4dbea840) > > > >Note that you can test it out via: > > > > cordova platform add https://na01.safelinks. > protection.outlook.com/?url=https%3A%2F%2Fgithub.com% > 2Fapache%2Fcordova-ios%234.5.0&data=02%7C01%7C% > 7Cdc0ae31e6f184ea4b6cc08d4f63b1d05%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0%7C636404181131226937&sdata=53sZxMQT60U3LMi1AVUCjfyYAVQf% > 2FouX6lcpa5mLMXY%3D&reserved=0 > > > >Upon a successful vote I will upload the archive to dist/, publish it to > >npm, and post the blog post. > > > >Voting guidelines: https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fgithub.com%2Fapache%2Fcord&data=02%7C01%7C% > 7Cdc0ae31e6f184ea4b6cc08d4f63b1d05%7Cfa7b1b5a7b34438794aed2c178de > cee1%7C0%7C0%7C636404181131226937&sdata=fYkZu7gESBe% > 2F1E1vfNP2lgo0qonhv25RzFNF%2B3IJslM%3D&reserved=0 > >ova-coho/blob/master/docs/release-voting.md > > > >Voting will go on for a minimum of 48 hours. > > > >I vote +1: > >* Ran coho audit-license-headers over the relevant repos > >* Ran coho check-license to ensure all dependencies and subdependencies > >have Apache-compatible licenses > >* Ensured continuous build was green when repo was tagged (see > >https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Ftravis-ci.org%2Fapache%2Fcordova-ios% > 2Fbuilds%2F272322381&data=02%7C01%7C%7Cdc0ae31e6f184ea4b6cc08d4f63b1d05% > 7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636404181131226937&sdata= > iEYu0v9DZ0KBn7RDPnaRhj6Hnsi0F2qYcMKpFQEBDiw%3D&reserved=0) > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org >
