For next release I want cordova-plugin-statusbar as I fixed it to work properly on iPhone X
2017-09-22 21:27 GMT+02:00 Steven Gill <[email protected]>: > Please review the blog post for the release > > https://github.com/apache/cordova-docs/pull/734 > > On Wed, Sep 20, 2017 at 4:38 PM, Steven Gill <[email protected]> > wrote: > > > Yeah I only released the plugins that people mentioned in this thread to > > release. I can fire up another plugins release next week. What plugins do > > people want reviewed/released? > > > > On Wed, Sep 20, 2017 at 4:36 PM, Simon MacDonald < > > [email protected]> wrote: > > > >> Just realized that cordova-plugin-file-transfer was never bumped. It > >> includes an important fix for apps. Without it new apps may be rejected > >> from the Play Store. > >> > >> > >> Simon Mac Donald > >> http://simonmacdonald.com > >> > >> On Wed, Sep 20, 2017 at 1:33 PM, Steven Gill <[email protected]> > >> wrote: > >> > >> > the ios release blog post tells users about the console plugin. > >> > http://cordova.apache.org/announcements/2017/09/08/ios-release.html > >> > > >> > I'll make sure to highlight these changes in the plugins release blog > >> post. > >> > > >> > Starting a new vote with console + compat only having minor bumps > >> > > >> > On Wed, Sep 20, 2017 at 8:16 AM, julio cesar sanchez < > >> > [email protected] > >> > > wrote: > >> > > >> > > There has been already a few people asking about the duplicate > >> symbols on > >> > > slack > >> > > > >> > > 2017-09-20 17:06 GMT+02:00 Simon MacDonald < > [email protected] > >> >: > >> > > > >> > > > IMHO both cordova-plugin-compat and cordova-plugin-console should > >> > receive > >> > > > minor version bumps. Neither breaks backwards compatibility so I > >> don't > >> > > feel > >> > > > like a major version bump is warranted. > >> > > > > >> > > > As well all of our core plugins that depend on > cordova-plugin-compat > >> > use > >> > > > the ^1.x in their semver so they would pull in the earlier version > >> of > >> > the > >> > > > compat plugin and in combination with the upcoming cordova-android > >> > 6.3.0 > >> > > > pretty much all apps will fail to build. > >> > > > > >> > > > When it comes to cordova-plugin-console we should also err on the > >> side > >> > of > >> > > > caution when it comes to the version number bump. I spent some > time > >> > this > >> > > > morning debugging an internal app that was using cordova-ios 4.5.0 > >> and > >> > > > cordova-plugin-console. It was failing to build because of > duplicate > >> > > code. > >> > > > If cordova-plugin-console 1.1.0 (not 2.0.0) has been release > before > >> > > > cordova-ios 4.5.0 the problem would not have existed. > >> > > > > >> > > > I think we need to be ready to start answering that question as to > >> why > >> > > apps > >> > > > using cordova-ios 4.5.0 don't build. Perhaps a quick blog post is > in > >> > > order? > >> > > > > >> > > > My recommendations is to restart this vote thread with the four > >> plugins > >> > > but > >> > > > tag their versions as [email protected], > >> > > > [email protected]. The device motion and device > >> orientation > >> > > > plugins can have any version number we want as they will not run > >> into > >> > the > >> > > > above problems. > >> > > > > >> > > > > >> > > > Simon Mac Donald > >> > > > http://simonmacdonald.com > >> > > > > >> > > > On Wed, Sep 20, 2017 at 1:44 AM, Steven Gill < > >> [email protected]> > >> > > > wrote: > >> > > > > >> > > > > Plugin vote is going to fail it seems due to the issue simon > >> found. > >> > > > > > >> > > > > Simons message: > >> > > > > "Failed > >> > > > > * Added cordova-plugin-camera to a project with cordova-android > >> 6.3.0 > >> > > > which > >> > > > > depends on cordova-plugin-compat and the build fails. > >> > > > > > >> > > > > The reason the build fails is that all of the cordova plugins > that > >> > > depend > >> > > > > on cordova-plugin-compat do so using a semver of ^1.0.0 or > ^1.1.0. > >> > > Since > >> > > > > compat was bumped to 2.0.0 when you install > cordova-plugin-camera > >> on > >> > > your > >> > > > > cordova-android 6.3.0 project it fails the semver and it pulls > in > >> the > >> > > > 1.1.0 > >> > > > > version. Now both compat and cordova-android deliver the same > >> classes > >> > > and > >> > > > > the build fails." > >> > > > > > >> > > > > I actually have 1.2.0 version of the plugin already tagged from > >> when > >> > I > >> > > > ran > >> > > > > the plugin process on Monday. It is identical to the 2.0.0 > version > >> > that > >> > > > is > >> > > > > being voted on. We can either stop the current vote thread and > >> start > >> > a > >> > > > new > >> > > > > one with 1.2.0 instead of 2.0.0, or we could continue the > current > >> > vote > >> > > > > thread and start a new one just for [email protected]. If we go with > >> > option > >> > > > 2, > >> > > > > we can release both 1.2.0 and 2.0.0. > >> > > > > > >> > > > > This is a good point to remember in the future. Deprecation > >> should be > >> > > > minor > >> > > > > not major bumps. > >> > > > > > >> > > > > > >> > > > > On Tue, Sep 12, 2017 at 11:43 PM, Shazron <[email protected]> > >> wrote: > >> > > > > > >> > > > > > Created PR for CB-13170 cordova-plugin-console > >> > > > > > https://github.com/apache/cordova-plugin-console/pull/25 > >> > > > > > > >> > > > > > On Tue, Sep 12, 2017 at 7:20 AM, Simon MacDonald < > >> > > > > > [email protected]> > >> > > > > > wrote: > >> > > > > > > >> > > > > > > Both of: > >> > > > > > > > >> > > > > > > cordova-plugin-device-motion > >> > > > > > > cordova-plugin-device-orientation > >> > > > > > > > >> > > > > > > should get their deprecation PR's merge and also released. > >> > > > > > > > >> > > > > > > Simon Mac Donald > >> > > > > > > http://simonmacdonald.com > >> > > > > > > > >> > > > > > > > >> > > > > > > On Mon, Sep 11, 2017 at 7:03 PM, Shazron <[email protected] > > > >> > > wrote: > >> > > > > > > > +1 on console. No PRs for that yet though so it's not > ready. > >> > > > > > > > > >> > > > > > > > On Tue, Sep 12, 2017 at 5:46 AM, Steven Gill < > >> > > > [email protected] > >> > > > > > > >> > > > > > > wrote: > >> > > > > > > > > >> > > > > > > >> Console should be released too since it has been moved > back > >> > into > >> > > > ios > >> > > > > > for > >> > > > > > > >> next release. https://issues.apache.org/jira > >> /browse/CB-13170 > >> > > > > > > >> > >> > > > > > > >> On Sep 11, 2017 2:04 PM, "Jesse" < > [email protected]> > >> > > wrote: > >> > > > > > > >> > >> > > > > > > >> > Android release is dependent on us releasing an > >> > > > > > > >> > updated cordova-plugin-compat > >> > > > > > > >> > > >> > > > > > > >> > Anyone have any reasons to not do a release? Anything > >> > > > outstanding > >> > > > > > > >> > anyone wants to get merged in before moving ahead with > a > >> > > plugins > >> > > > > > > >> > release? Any other comments on the topic? > >> > > > > > > >> > > >> > > > > > > >> > Cheers, > >> > > > > > > >> > Jesse > >> > > > > > > >> > > >> > > > > > > >> > > >> > > > > > > >> > @purplecabbage > >> > > > > > > >> > risingj.com > >> > > > > > > >> > > >> > > > > > > >> > >> > > > > > > > >> > > > > > > ------------------------------ > ------------------------------ > >> > > > --------- > >> > > > > > > To unsubscribe, e-mail: [email protected] > >> > > > > > > For additional commands, e-mail: > [email protected] > >> > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > > > >
