3. Promises, ugh. Try reject OR throw, not both.
https://github.com/psychogenic/cordova-linux/blob/69a4dc92cae54e86761ad286c38710df8693b244/src/cordova/Api.js#L256
reject does not terminate the execution, it will still throw after the
reject here...
4. "cordova clean -> Cleanup project from build artifacts". Are they
"produced" by the build? Then you clean that up.
On Tue, Jan 16, 2018 at 9:49 AM, Pat Deegan <pat.cordova...@psychogenic.com>
wrote:
> Hi,
>
> First off, thanks for the answers.
>
> On 2018-01-15 08:25 PM, Shazron wrote:
> > 1. Core platforms get the reserved names. Third-party platforms are named
> > after what I presume is their repo name (not 100% sure on that last
> part).
>
> Ok, cool--I can wait for a nice reserved name, down the road.
>
> >
> > 2. I would check out a platform example, i.e. 'ios':
> > Is this what you were looking for?
>
> Yes, perfect. Will base mods on that.
>
> >
> > 3. What do you mean by ugly? Example. AFAIK it's just "throw new
> > CordovaError('error string')"
>
> Ok. By ugly I mean instead of getting some:
>
> "Error, cannot proceed: error string"
>
> or something similar, the output is instead:
>
> === snip ===
>
> (node:1025) UnhandledPromiseRejectionWarning: Error
> [ERR_UNHANDLED_ERROR]: Unhandled error. (error string)
> at EventEmitter.emit (events.js:140:19)
> at EventEmitter.module.exports.emit
> (/tmp/SomeApp/node_modules/cordova-common/src/events.js:71:17)
> at Object.module.exports.error
> (/tmp/SomeApp/platforms/cordova-linux/cordova/logger.js:54:12)
> at Api.rejectAndThrow
> (/tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:258:9)
> at /tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:280:8
> at new Promise (<anonymous>)
> at Api.build (/tmp/SomeApp/platforms/cordova-linux/cordova/Api.js:
> 270:9)
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-
> lib/src/cordova/compile.js:40:30
> at
> /usr/local/lib/node_modules/cordova/node_modules/cordova-
> lib/src/util/promise-util.js:30:24
> at _fulfilled
> (/usr/local/lib/node_modules/cordova/node_modules/cordova-
> lib/node_modules/q/q.js:787:54)
> (node:1025) UnhandledPromiseRejectionWarning: Unhandled promise
> rejection. This error originated either by throwing inside of an async
> function without a catch block, or by rejecting a promise which was not
> handled with .catch(). (rejection id: 2)
> (node:1025) [DEP0018] DeprecationWarning: Unhandled promise rejections
> are deprecated. In the future, promise rejections that are not handled
> will terminate the Node.js process with a non-zero exit code.
>
>
> === /snip ===
>
> Yeah, it contains the error string up there, at the top, but seems like
> a pretty messy exit.
>
> I guess I kind of expect a catch somewhere above my call to make this
> output more user friendly. Maybe it's an issue with my setup?
>
>
> >
> > 4. I couldn't find a question in there.
>
> Yeah, I sent the email somewhat incomplete there... the short of it was
> "is it a faux pas to leave some built packages from previous versions
> lying around after a 'clean'?".
>
> It's currently setup such that all the generated files/intermediate
> results of a build are cleaned up on 'clean', but the versioned packages
> created are left intact (unless you actually remove the platform). I
> like the "safety" of keeping older versions around, but will eliminate
> them on 'clean' if it's the convention/expectation.
>
>
> >
> > TBH you would be the only person working on this, and there is no point
> in
> > putting this in the dead cordova-ubuntu repo. I would keep it in your
> repo
> > for now since that will be the fastest to iterate on since you won't have
> > Apache committer privileges yet, and you will be blocked by us having to
> > pull it in. Once it gets to a usable state, send a proposal to donate
> your
> > repo to Cordova in this dev@ list and we will proceed from there.
>
>
> Sounds great, will do.
>
> Thanks,
> P
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>
