On Mon, Apr 30, 2018 at 12:37 PM Wojciech Trocki <wtro...@gmail.com> wrote:
> > It's nice but it's just syntactic sugar so if it is slower than the > current > method I'd say no. > Linked PR[1] has no performance impact for end users. > It's not changing any current Cordova API etc. so it's pretty safe. > [1] https://github.com/apache/cordova-android/pull/439 Maybe I'm not understanding the goal here and it would be clearer with an example, but it looks like this would split each action out into its own class? I'm not sure what advantage there is to that, since you'd lose access to all the CordovaPlugin members like the webview and CordovaInterface. From a plugin author standpoint, a @CordovaMethod annotation to expose specific plugin methods to JS would be ideal, but it's not such a convenience that it's worth any performance hit. The string-based execute is clunky, but not all that much of a problem if you just use it to dispatch to other methods. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
