Sadly going to change my vote to -1 and cancel this release because I realized it includes a minor refactoring that is incompatible with node 4. While we're not officially supporting node 4 after April 30th, our blog post[1] said that we would do a major version bump when dropping support, and it's pretty terrible to knowingly break compatibility in a patch-level release.
I've checked and reverting one commit will give us back node 4 support with no functionality changes, so I'm going to do that on the 2.2.x branch and make a new release of [email protected]. 1: http://cordova.apache.org/news/2016/10/01/0.x-4.x-deprecation-timeline.html On Thu, May 31, 2018 at 2:40 PM Jesse <[email protected]> wrote: > > +1 > * npm test > * coho verify-archive > * coho audit-license-headers > > > > @purplecabbage > risingj.com > > On Thu, May 31, 2018 at 2:10 PM, Steven Gill <[email protected]> wrote: > > > +1 > > > > * Ran npm test > > * coho audit-license-header > > * coho verify-archive > > > > On Thu, May 31, 2018 at 4:40 AM Chris Brody <[email protected]> wrote: > > > > > +1 > > > > > > On May 31, 2018 12:21 AM, "Darryl Pogue" <[email protected]> wrote: > > > > > > > Please review and vote on this Tools Release by replying to this email > > > > (and keep discussion on the DISCUSS thread) > > > > > > > > Release issue: > > > > https://issues.apache.org/jira/browse/CB-14112 > > > > > > > > Packages have been published to dist/dev: > > > > https://dist.apache.org/repos/dist/dev/cordova/CB-14112/ > > > > > > > > The packages were published from the corresponding git tag: > > > > cordova-common: 2.2.2 (e98283d030) > > > > > > > > Upon a successful vote I will upload the archives to dist/, publish > > > > them to npm, and post the corresponding blog post. > > > > > > > > Voting guidelines: > > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/ > > release-voting.md > > > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > > > * Ran coho check-license to ensure all dependencies and > > > > sub-dependencies have Apache-compatible licenses > > > > * Ensured continuous build was green when repos were tagged > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
