I vote +1 * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and sub-dependencies have Apache-compatible licenses * Ensured continuous build was green when repos were tagged * installed and ran tests locally
@purplecabbage risingj.com On Mon, Jun 18, 2018 at 3:14 PM, Chris Brody <chris.br...@gmail.com> wrote: > Plenty of discussion in other threads, something definitely went wrong, > lesson learned. I would like to kindly request actual votes in this thread > in order to unblock my work. > > In case of -1 vote please just give a quick reason so that it would be > possible for me to rectify any such issues. > > I would really like to move forward with this patch if we do not identify > any major issues in order to resolve the npm audit issues asap. We can > always make a follow-up patch if needed. > > Thanks in advance, best regards, > > Chris > > On Jun 18, 2018 7:06 AM, "Chris Brody" <chris.br...@gmail.com> wrote: > > > This vote was requested last Friday but received votes, positive or > > negative. This patch release is needed to resolve npm audit issues. > > > > Please review and vote on this cordova-common 2.2.4 (patch release) > > by replying to this email (and keep discussion on the [DISCUSS] thread) > > > > Release issue: https://issues.apache.org/jira/browse/CB-14138 > > > > Purpose is to release a single version of cordova-common with npm > > audit issues fixed, working on cordova-android, cordova-ios, and all > > other tools and platform packages. > > > > Artifacts for this cordova-common patch release have been published to > > dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/CB-14138/ > > > > The package artifacts were published from their corresponding git tag(s): > > > > cordova-common: 2.2.4 (494edddc23) > > > > Upon a successful vote I will upload the archives to dist/, publish > > them to npm, and post the corresponding blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/ > release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > sub-dependencies have Apache-compatible licenses > > * Ensured continuous build was green when repos were tagged > > > > Thanks and best regards, > > > > Chris > > > > https://twitter.com/brodybits > > >
