1. Previously we had node_modules bundled. We couldn't bundle ios-deploy because of its viral license. The only issue is that it tries to build on Windows, but that should be easily fixed: https://github.com/ios-control/ios-deploy/issues/355 . There should be no problem in using a dependency from the command line, we just have to prepend the path from `npm bin` to the PATH variable, then run the executable (just have to exclude Windows from this case). 2. The risk mismatch is only based off the Xcode version installed since it is built natively and relies on Xcode frameworks (Xcode 9.4 was missing files and ios-deploy had to work around it). We don't really have a matrix of dependencies, so the latest is always used for ios-deploy.
Technically we don't even have to install anything now, if we prefix the npm command with `npx`: `npx ios-deploy a b c` npx has been available since npm@5.2.0 According to this: https://nodejs.org/en/download/releases/ it would mean that we can only rely on npx being installed if the user has node 8.2.0, which is a ways off from being our default node version. On Thu, Aug 2, 2018 at 10:41 PM Jan Piotrowski <piotrow...@gmail.com> wrote: > > > 1. Why not make ios-deploy a dependency of cordova-ios that would then > > be automatically installed? > > Historically, I think, commands that should be able to be called via > the command line had to be installed globally with npm to work. Is > this not the case any more? > > 2018-08-02 15:26 GMT+02:00 Chris Brody <chris.br...@gmail.com>: > > A couple things that I think are not clear for > > <https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/guide/platforms/ios/index.md#deployment-tools>: > > > > 1. Why not make ios-deploy a dependency of cordova-ios that would then > > be automatically installed? > > > > 2. Is there a risk of mismatch between a users installed ios-deploy > > version and a users Cordova version? Should this be documented, if so? > > > > I think the answer to 1 is that ios-deploy sometimes needs to be > > installed with more system privs. I am not 100% sure of this, would > > love some confirmation from an expert. And I think this is not really > > a problem most of the time. > > > > I think the answer to 2 is "not yet". > > > > Confirmation would be really helpful. > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
