The vote has now closed. The results are: Positive Binding Votes: 3
* Steven Gill * Gandhi Rajan * Christopher J. Brody Negative Binding Votes: 0 The vote has passed. On Thu, Aug 9, 2018 at 7:49 PM Steven Gill <[email protected]> wrote: > > +1 > > On Tue, Aug 7, 2018 at 5:21 AM Chris Brody <[email protected]> wrote: > > > Thanks Gandhi. Can I get one more review on this one? > > On Mon, Aug 6, 2018 at 11:28 PM gandhi rajan <[email protected]> > > wrote: > > > > > > +1 > > > > > > On Tuesday, July 31, 2018, Chris Brody <[email protected]> wrote: > > > > > > > Please review and vote on this [email protected] patch release by > > > > replying to this email (and keep discussion on the DISCUSS thread). > > > > > > > > Release issue: https://issues.apache.org/jira/browse/CB-14230 > > > > > > > > The archive has been published to dist/dev: > > > > https://dist.apache.org/repos/dist/dev/cordova/CB-14230/ > > > > > > > > The package was published from its corresponding git tag: > > > > > > > > cordova-browser: 5.0.4 (c61ce21186) > > > > > > > > Note that you can test it out via: > > > > > > > > cordova platform add > > https://github.com/apache/cordova-browser#5.0.4 > > > > > > > > Upon a successful vote I will upload the archive to dist/, publish it > > > > to npm, and post the blog post. > > > > > > > > Voting guidelines: > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > > > I vote +1: > > > > * Ran coho audit-license-headers over the relevant repos > > > > * Ran coho check-license to ensure all dependencies and > > > > subdependencies have Apache-compatible licenses > > > > * Ensured continuous build was green when repo was tagged > > > > * able to add to > > > > https://github.com/brodybits/cordova-dialogs-bootstrap-test using > > > > cordova platform add github:brodybits/cordova-browser#5.0.x, run, and > > > > try a couple dialogs with [email protected] (bundled with deprecated node > > > > v4.9.1) on Windows Edge, Windows Chrome, and macOS Safari > > > > * able to add to > > > > https://github.com/brodybits/cordova-dialogs-bootstrap-test using > > > > cordova platform add github:brodybits/cordova-browser#5.0.x, run, and > > > > try a couple dialogs with [email protected] (bundled with node v8.11.3) > > > > * more details in https://github.com/apache/cordova-browser/pull/55 > > > > > > > > Proposed blog post in: https://github.com/apache/cordova-docs/pull/857 > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > > > -- > > > Regards, > > > Gandhi > > > > > > "The best way to find urself is to lose urself in the service of others > > !!!" > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
