Thanks Raphael. I will likely add this information to the GitHub entries for the sake of extra clarification. On Mon, Sep 17, 2018 at 7:39 AM <[email protected]> wrote: > > I thought it was already clear from the discussion in cordova-lib#688. The > gist is: > > - cordova-lib#688 is a hotfix of logic that should never have been where > it is in the first place (from a design point of view) > - cordova-common#50 fixes the underlying problem for all users of > `superspawn` and makes the code that is fixed in cordova-lib#688 obsolete > altogether. > But since this change's impact is much larger, it also requires a lot > more testing. So it's not quite ready yet. > > Thus, hotfix in the next patch release, proper fix when it's ready. > > Am Mo., 17. Sep. 2018 um 13:01 Uhr schrieb Chris Brody < > [email protected]>: > > > Hi Raphael, > > > > I gotta say I don't understand a couple things: > > * cordova-lib #688 > > * why fix it in cordova-lib in a patch one day then fix it in > > cordova-common another day > > > > The changes cordova-lib#688 do see to be similar (using which for > > win32) to code that is actually replaced in cordova-common#50. So > > there is a correlation that I do not understand. > > > > An explanation here or on GitHub would be really helpful. > > On Mon, Sep 17, 2018 at 2:38 AM <[email protected]> wrote: > > > > > > Hey Chris! > > > > > > Could you please include the changes from > > > https://github.com/apache/cordova-lib/pull/688 in the patch? > > > > > > They have already been approved by Jan and I think we should release it > > as > > > an intermediate solution until > > > https://github.com/apache/cordova-common/pull/50 lands. > > > > > > Thanks in Advance, > > > Raphael > > > > > > Chris Brody <[email protected]> schrieb am So., 16. Sep. 2018, > > 23:32: > > > > > > > Does anyone have any reason to delay a cordova-lib minor tools release? > > > > > > > > Any outstanding patches to land? > > > > > > > > If not, I will start the release tomorrow (in 24 hours), with changes > > > > merged from: https://github.com/apache/cordova-lib/pull/693 > > > > > > > > The versions to be released are: > > > > - [email protected] > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [email protected] > > > > For additional commands, e-mail: [email protected] > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
