+1 * Looked at the commits manually that should fix the bugs * Confirmed via the content of the linked .tgz file that `bin\cordova.cmd --version` does not crash on Node4 and does not throw an exception on newer Nodes when creating the Telemetry file * Verified sha1s match tags with `coho verify-tags -g` (and documented the step in https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md along the way) Am Do., 27. Sep. 2018 um 14:53 Uhr schrieb <[email protected]>: > > I vote +1: > > * Installed archive from dist/dev and successfully ran some routine tasks > * Successfully ran some tasks using Node.js 4 > * Checked that the telemetry prompt was working correctly > > Thanks for taking care of this Chris! > > Am Do., 27. Sep. 2018 um 13:06 Uhr schrieb Chris Brody < > [email protected]>: > > > Please review and vote on this [email protected] tools hotfix release > > by replying to this email (and keep discussion on the DISCUSS thread). > > > > Release issue: https://github.com/apache/cordova-cli/pull/342 > > > > Both tools have been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/GH-342/cordova-8.1.1.tgz > > > > The packages were published from their corresponding git tags: > > cordova-cli: 8.1.1 (3f8d9c88d6) > > > > Upon a successful vote I will upload the archives to dist/, publish > > them to npm, and post the corresponding blog post. > > > > Voting guidelines: > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and > > subdependencies have Apache-compatible licenses > > * Ensured continuous build was green when repos were tagged > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > >
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
