I vote +1 - coho verify-archive - checked out tag, ran tests - CI green
@purplecabbage risingj.com On Fri, Oct 5, 2018 at 1:50 PM <raphine...@gmail.com> wrote: > I vote +1: > - Successfully installed archive from dist/dev > - Successfully ran some routine tasks including `cordova platform ios` > > Am Fr., 5. Okt. 2018 um 22:23 Uhr schrieb Oliver Salzburg < > oliver.salzb...@gmail.com>: > > > I vote +1 > > > > - Confirmed sigs & hashes with `coho verify-archive` [1] > > - Verified sha1s match tags with `coho verify-tags` > > - Checked out the branch and ran `npm test` > > - Continuous build was green when repo was tagged > > > > [1] The signature is a match, but I have not verified the signature yet. > > > > On 2018-10-05 21:15, Chris Brody wrote: > > > Please review and vote on this cordova-cli@8.1.2 tools patch release > > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > > > Release issue: https://github.com/apache/cordova-lib/issues/706 > > > > > > Both tools have been published to dist/dev: > > > > https://dist.apache.org/repos/dist/dev/cordova/GH-706/cordova-8.1.2.tgz > > > > > > The packages were published from their corresponding git tags: > > > > > > cordova-cli: 8.1.2 (739108ddc6) > > > > > > Upon a successful vote I will upload the archives to dist/, publish > > > them to npm, and post the corresponding blog post. > > > > > > Voting guidelines: > > > > > > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > > > Voting will go on for a minimum of 48 hours. > > > > > > I vote +1: > > > * Ran coho audit-license-headers over the relevant repos > > > * Ran coho check-license to ensure all dependencies and > > > subdependencies have Apache-compatible licenses > > > * Ensured continuous build was green when repos were tagged > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
