I vote +1 - listed package git ID matches 4.0.0 on GitHub - it is green on GitHub - I downloaded & extracted the proposed TGZ file; diff -u --recursive shows me that all significant artifacts are in place with no changes - npm audit shows me no warnings
As a side question: my understanding from cordova-coho is that whenever we make a new release, the next step is to bump the version with the -dev suffix: https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md#re-introduce--dev-suffix-to-versions-on-master-and-commit I would personally strongly favor that we continue to do this on Cordova. I do this with many of my own projects and Prettier seems to do this as well. While many projects do not do this, I think the major advantage is that it will show up whenever people install from GitHub or test contributions from PRs. On Thu, Mar 26, 2020 at 12:21 PM Bryan Ellis <er...@apache.org> wrote: > Please review and vote on this Cordova Common Major Release v4.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/common-v4.0.0 > > The package was published from its corresponding git tag: > cordova-common: 4.0.0 (9e81ca8b45) > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * NPM Audit > * NPM Test >
