I vote +1 * coho verify-archive OK * CI is green * Changes make sense
On Fri, May 15, 2020 at 8:21 AM Niklas Merz <niklasm...@apache.org> wrote: > I vote +1 > > * verify signature and hash with coho verify archive > * npm install and npm audit success > * CI green for tag > * verify tag with coho > * tests green locally > * check license headers with coho > > Thank you Bryan for your work. > > > May 15, 2020 3:25 AM, "Bryan Ellis" <er...@apache.org> wrote: > > > Please review and vote on this cordova-common release v4.0.1 > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > The archive has been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/common-4.0.1 > > > > The package was published from its corresponding git tag: > > cordova-common: 4.0.1 (13e06971c1) > > > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog > > post. > > > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > > > Voting will go on for a minimum of 48 hours. > > > > I vote +1: > > * Ran coho audit-license-headers over the relevant repos > > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible > > licenses > > * Ensured continuous build was green when repo was tagged > > * NPM Audit (exception for dev related dependency) > > * NPM Test > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > -- Tim Brust, Product Engineer tim.br...@sinnerschrader.com T +49 40 398855 315 SinnerSchrader Deutschland GmbH | SinnerSchrader Group Völckersstraße 38, 22765 Hamburg, Germany Amtsgericht Hamburg HRB-Nr. 63663 Geschäftsführer: Matthias Schrader (Sprecher), Jürgen Alker, Dr. Axel Averdung, Holger Blank, Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag https://www.sinnerschrader.com | NEXT AGENCY
