Looks good :) When you merge into master, this is where a —squash would be appropriate - it only needs to be one commit in the history. I do this all the time with lots of temporary “work” commits and squash them all with a nice message.
— Dr Peter M. Kelly [email protected] PGP key: http://www.kellypmk.net/pgp-key <http://www.kellypmk.net/pgp-key> (fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966) > On 1 Jan 2015, at 8:19 pm, jan i <[email protected]> wrote: > > On 1 January 2015 at 13:25, Peter Kelly <[email protected]> wrote: > >>> On 1 Jan 2015, at 7:11 pm, jan i <[email protected]> wrote: >>> >>> just pushed a version that allows multiple zip files open. Remark cannot >>> have multiple files open inside a zip file, seems to be a limitation in >>> minizip. >>> >>> looking forward for comments. >> >> Looks good, I would just suggest dynamically allocating the myZipStorage >> objects using malloc/free - that way we don’t have any arbitrary limit on >> the number of files that can be open at any one time. Conceptually they’re >> just objects like anything else; it seems it would be appropriate to define >> a public type DFExtZipHandle or similar just like we do for any type of >> object; you then get type checking for free from the compiler. >> > > your wish just came through, just pushed that change as well. > > I will update master a bit later and clean origin for the RTC_platform > branch. > > rgds > jan i > > >> >> — >> Dr Peter M. Kelly >> [email protected] >> >> PGP key: http://www.kellypmk.net/pgp-key <http://www.kellypmk.net/pgp-key> >> (fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966) >> >>
