[
https://issues.apache.org/jira/browse/COR-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339002#comment-14339002
]
Peter Kelly commented on COR-48:
--------------------------------
The patch looks good. There were just a couple of warnings under Xcode about
implicit declarations of xmalloc; these were easily fixed by adding #include
"DFPlatform.h" at the top of the files.
I've tested this under 64-bit Ubuntu (with valgrind --leak-check=full) with
gcc, 64-bit Windows 7 with VS 2013, and 64-bit OS X with Xcode/clang. All seems
fine.
Thanks Gabriella :)
Next up is to replace the calls to calloc and realloc. We also need to do the
same thing for strdup, as this calls malloc internally (that is, we need an
xstrdup function). I think that's the only other function we're using in the C
library that allocates memory.
> Add x*alloc and xfree functions, change malloc() to xmallox() in non-3rd
> party directories
> ------------------------------------------------------------------------------------------
>
> Key: COR-48
> URL: https://issues.apache.org/jira/browse/COR-48
> Project: Corinthia
> Issue Type: Improvement
> Components: DocFormats - platform
> Affects Versions: 0.5
> Reporter: Gabriela Gibson
> Priority: Minor
> Attachments: logmesg.txt, malloc.patch
>
>
> Part 1 of the project, this just changes the malloc() calls and adds the new
> x*alloc/xfree functions.
> Tested with ./bin/dfutil -normalize <some random html file>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
