On Tue, Apr 7, 2015 at 3:21 PM, jan i <j...@apache.org> wrote: > Hi. > > Just had a look at your commits (to be correct, looked at the test case > change, when this one arrived), they are 100% correct, please keep up the > good work. > > core and platform are in production so of course a bit more sensitive to > changes. The odf filter its not yet > production, so fell free to commit mini-changes as you feel they are ready. > > Ok ;-)
Just to dip my toes in(gingerly), I added a little stub to dfutil -pp. Gotta start somewhere! G > rgds > jan i. > > > > > On 7 April 2015 at 16:08, <g...@apache.org> wrote: > > > Repository: incubator-corinthia > > Updated Branches: > > refs/heads/master 7799c53ab -> ebd3c933f > > > > > > Remove duplicate DFPlatform.h include. > > > > * DocFormats/core/src/lib/DFFilesystem.c > > Remove duplicate DFPlatform.h include. > > > > > > Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo > > Commit: > > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/ebd3c933 > > Tree: > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/ebd3c933 > > Diff: > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/ebd3c933 > > > > Branch: refs/heads/master > > Commit: ebd3c933f4865133250e834c5f96b18a43fe6846 > > Parents: 7799c53 > > Author: Gabriela Gibson <g...@apache.org> > > Authored: Tue Apr 7 15:08:02 2015 +0100 > > Committer: Gabriela Gibson <g...@apache.org> > > Committed: Tue Apr 7 15:08:02 2015 +0100 > > > > ---------------------------------------------------------------------- > > DocFormats/core/src/lib/DFFilesystem.c | 1 - > > 1 file changed, 1 deletion(-) > > ---------------------------------------------------------------------- > > > > > > > > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/ebd3c933/DocFormats/core/src/lib/DFFilesystem.c > > ---------------------------------------------------------------------- > > diff --git a/DocFormats/core/src/lib/DFFilesystem.c > > b/DocFormats/core/src/lib/DFFilesystem.c > > index 358b70e..6c1a1bc 100644 > > --- a/DocFormats/core/src/lib/DFFilesystem.c > > +++ b/DocFormats/core/src/lib/DFFilesystem.c > > @@ -22,7 +22,6 @@ > > #include "DFBuffer.h" > > #include <DocFormats/DFError.h> > > #include "DFCharacterSet.h" > > -#include "DFPlatform.h" > > #include "DFCommon.h" > > #include <assert.h> > > #include <errno.h> > > > > > -- Visit my Coding Diary: http://gabriela-gibson.blogspot.com/
