Specific comments below: On 9 August 2015 at 18:25, <orc...@apache.org> wrote:
> Repository: incubator-corinthia > Updated Branches: > refs/heads/master f17a5c777 -> 75ef795dd > > > Expand .gitignore cases > > Update to .gitignore to exclude places that are only populated by > editing and builds and never carried in the repository. Added more > comments to make the principle clear, with a little redundancy in the > case of Visual Studio artifacts. > > > Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo > Commit: > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/002851b3 > Tree: > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/002851b3 > Diff: > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/002851b3 > > Branch: refs/heads/master > Commit: 002851b3695cf249162197a4fff2386b90c5d314 > Parents: f17a5c7 > Author: Dennis Hamilton <orc...@apache.org> > Authored: Sun Aug 9 09:24:34 2015 -0700 > Committer: Dennis Hamilton <orc...@apache.org> > Committed: Sun Aug 9 09:24:34 2015 -0700 > > ---------------------------------------------------------------------- > .gitignore | 36 +++++++++++++++++++++++++++++++----- > 1 file changed, 31 insertions(+), 5 deletions(-) > ---------------------------------------------------------------------- > > > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/002851b3/.gitignore > ---------------------------------------------------------------------- > diff --git a/.gitignore b/.gitignore > index 700fbbf..8343cc6 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -1,4 +1,4 @@ > -# .gitignore UTF-8 > 2015-05-17 > +# .gitignore 0.05 UTF-8 > 2015-08-09 > # > # CORINTHIA/ROOT > # ============== > @@ -10,14 +10,40 @@ > # part of a structure where anyone can do multiple flavors of builds > # along-side the source without cluttering the repository iself. > > +## ELIMINATE AUTHORING/FILE-SYSTEM ARTIFACTS > +## ----------------------------------------- > > -# Build results > -build*/ > - > -# External downloads > +# Editing backup and working files > +*~ > +*# > > # Finder directory status files (OS X) > .DS_Store > > +## ELIMINATION OF VISUAL STUDIO SOLUTIONS > +## -------------------------------------- > + > +# Do not include working solutions in the repository tree. For Corinthia, > +# these will be built/extracted dynamically into the build/ folder as > needed > +# and will not appear directly in the source tree. > + > +*.sln > +*.vcxproj > +*.vcxproj.filters > These are in the build directory, if you find then anywhere else it is a problem you should be aware of and remove. When you add them to .gitignore people do not see the problem. > + > +## KEEP BUILDS IN THE BUILD/ FOLDER > +## -------------------------------- > > +external/* > +# Do not include any externals in the repository > This directory do not exist, why exclude that, then you should exclude all directories (apart from those in the repo). > + > +build*/ > +# If all build operations are carried out in either the build/ folder or > +# outside of the repository folder, they will be automatically excluded > from > +# the repository. > + > +# 0.05 2015-08-09 Add additional build exclusions based on the recommended > +# for GitHub and experience with ephemeral artifacts on Windows. > Based > +# on an 0.04 from another project (orcmid). > +# > # *** end of .gitignore *** > > I ask you to at least make the corrections stated above. rgds jan i.
