Re: Stats Patch API Discussion

[Jan Lehnardt]

On 20 Feb 2009, at 02:51, Robert Dionne wrote:

I"m seeing the same kinds of errors. The suite ran once from Futon but tends to fail on delayed_commits. It fails using runner also.

But it is working. I'm adding some functions to erl-couch to call stats from erlang clients. I've tried _stats and _stats/couchdb/ request_time. I'm getting numbers back.

Hi Robert,

try running the delayed commits test a number of times.
I found it to be an unstable test that sometimes fails, but
mostly succeeds, even on trunk.

It's very clean and the Eunit stuff is clearly a big win.

Thanks! :)

Cheers
Jan
--

On Feb 19, 2009, at 8:16 PM, Chris Anderson wrote:

Having trouble with the build. Or, rather, it builds just fine, but

even the basics test seems to be failing, with lots of stuff like this

in the logfile:

[error] [<0.43.0>] {error_report,<0.21.0>,
             {<0.43.0>,supervisor_report,
              [{supervisor,{local,couch_secondary_services}},
               {errorContext,child_terminated},
               {reason,normal},
               {offender,[{pid,<0.110.0>},
                          {name,stats_collector},
                          {mfa,{couch_stats_collector,start,[]}},
                          {restart_type,permanent},
                          {shutdown,brutal_kill},
                          {child_type,worker}]}]}}
[error] [<0.43.0>] {error_report,<0.21.0>,
             {<0.43.0>,supervisor_report,
              [{supervisor,{local,couch_secondary_services}},
               {errorContext,child_terminated},
               {reason,normal},
               {offender,[{pid,<0.111.0>},
                          {name,stats_aggregator},
                          {mfa,{couch_stats_aggregator,start,[]}},
                          {restart_type,permanent},
                          {shutdown,brutal_kill},
                          {child_type,worker}]}]}}

It really could be just me. Anyone else tried to run the tests on the
current version of the branch?

http://github.com/janl/couchdb/tree/old-stats-new

I'm know I ran `make clean` and rebootstrapped. I'm launching CouchDB
with `make dev && utils/run`. It seems like Couch is running just
fine, but eventually the failure of couch_stats_* to boot properly is
causing it to drop http requests.

The code looks clean and well documented, so this should be easy to
fix, or maybe it's something on my end. It'd be helpful to hear if it
works for others.

Chris

--
Chris Anderson
http://jchris.mfdz.com