On Thu, Feb 26, 2009 at 1:58 PM, Jan Lehnardt <[email protected]> wrote: > > On 26 Feb 2009, at 19:51, Paul Davis wrote: > >> A small suggestion might be to move the registering of stat >> descriptions next to the code that records the stats so that adding >> new recordings keeps code separate. Not a major concern by any means >> though. > > There might be multiple place a metric is counted. Where do I put > the description definition then? :) > > I pondered having the stats_collector initializing all metrics upfront > for speed reasons on collector:increment() calls, but the speedup > was negligible. If we ever move counters into their own ets tables, > this should be done anyway which is when we can move the > description definition there. > > Having the modules initialize the metrics doesn't work either > because couch_stat_collector is launched after e.g. couch_db > which would want to do a register. >
Touché > Cheers > Jan > -- > >> >> HTH, >> Paul Davis >> >> On Thu, Feb 26, 2009 at 12:33 PM, Jan Lehnardt <[email protected]> wrote: >>> >>> Hi, >>> >>> thanks for your feedback! r748217 has some new goodies. >>> >>> On 23 Feb 2009, at 15:51, Jan Lehnardt wrote: >>>> >>>> So far we have: >>>> >>>> {couchdb, open_databases} >>>> {couchdb, request_time} >>>> >>>> {httpd, bulk_requests} >>>> {httpd, head_requests} >>>> {httpd, get_requests} >>>> {httpd, put_requests} >>>> {httpd, post_requests} >>>> {httpd, delete_requests} >>>> {httpd, copy_requests} >>>> {httpd, move_requests} >>>> >>>> {httpd, document_copies} >>>> {httpd, document_creates} >>>> {httpd, document_deletes} >>>> {httpd, document_moves} >>>> {httpd, document_reads} >>>> {httpd, document_updates} >>>> {httpd, requests} >>>> {httpd, temporary_view_reads} >>>> {httpd, view_reads} >>>> >>>> {http_status_codes, Code} (Code is one of 200, 201, 203 ... ) >>>> >>>> I'd suggest >>>> - to move the `document_*` keys from `httpd` to `couchdb`, >>> >>> I removed the `document_*` metrics and replaced them with >>> `database_reads` / `_changes` metrics. They count metrics even >>> if the request does not come through the HTTP API and from >>> a low-level perspective, document creates, updates and deletes >>> are really just database changes (or appends). So only reads >>> and writes are tracked on this level. >>> >>>> - to rename `httpd` to `http`. >>> >>> Didn't happen. >>> >>> >>>> Is there anything else that you think should look different? >>> >>> I added human readable descriptions to each metric. >>> >>> Anything else you'd like to see? Otherwise I'd call the API final >>> except for more metrics that we might add over time. >>> >>> Cheers >>> Jan >>> -- >>> >>> >> > >
