[
https://issues.apache.org/jira/browse/COUCHDB-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733528#action_12733528
]
Chris Anderson commented on COUCHDB-421:
----------------------------------------
just looking at the new patch. definitely solid. One think I see: the
changes_response_type/1 function may be a smell that we shouldn't have eg:
continuous=true
or
longpoll=true
but rather an single query parameter like:
connection=continuous
or
connection=longpoll
with a default of "normal".
This way we don't need a helper function to parse it and we also don't need to
worry about cases where a user (or library) does something silly like:
continuous=true&longpoll=true
This involves changing the API but maybe it's worth it?
> add longpolling for _changes
> ----------------------------
>
> Key: COUCHDB-421
> URL: https://issues.apache.org/jira/browse/COUCHDB-421
> Project: CouchDB
> Issue Type: New Feature
> Affects Versions: 0.10
> Reporter: Benoit Chesneau
> Attachments: longpoll.diff, longpoll2.diff
>
>
> Implement longpolling on _changes. Instead of continuous, longpolling hold
> request until an update is available then close it. The client will have
> to ask a new connection. Should solve problem for XHR's that don't have that
> status changed (on ie, opera..) .
> I've put all the code in my github repo :
> http://github.com/benoitc/couchdb/tree/longpoll
> diff against trunk is attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
