On Sep 5, 2009, at 4:37 PM, [email protected] wrote:

-compare_rep_history(S, T) when length(S) =:= 0 orelse length(T) =:= 0 ->
+compare_rep_history([], []) ->

Hi Jan, this patch isn't quite right and can crash the replicator. The old version checked if _either_ list was empty and aborted the comparison; the new version requires that _both_ are empty. If the histories have different lengths we'll get a badmatch in the next clause

compare_rep_history([{S}|SourceRest], [{T}|TargetRest]=Target) ->

I think what you wanted was

compare_rep_history(S, T) when S =:= [] orelse T =:= [] ->

Best, Adam

Reply via email to