On 20 Mar 2010, at 20:06, Paul Davis wrote: > On Sat, Mar 20, 2010 at 2:31 PM, Noah Slater <[email protected]> wrote: >> I think faulty test case should block the release, if I am to have any >> future sanity preparing releases. I don't want to delay and longer, so if >> you guys are absolutely sure this is a test error and not code error, then I >> propose that the test be commented out. Our tests form a contract between >> us, internally, and our users. If that contract has a bug, it should be >> removed or fixed - or it simply dilutes the importance of contract. If some >> one comments out the test, and we agree it is not indicative of an important >> bug, I can call the vote within hours. >> > > I'd have to agree on this. From the point of view of a release, if a > test reports a failure then it should be made to not report a failure. > If that's accomplished by disabling it, then there will be a commit > with a message that explains why it was disabled and etc and such on > and so forth.
I'd do that if the test was failing for me :) Cheers Jan --
