I see, cool. I just saw the patch, was wondering how all these terminate functions were being called, and started refreshing my memory on these bits. They aren't all that intuitive.
Well it's a good idea to try it, as it's harmless and might fix the problem. Thanks Filipe, Randall, and Paul, for the schooling On Sep 25, 2010, at 11:57 AM, Paul Davis wrote: > Bob, > > If memory serves, this thread doesn't have anything to do with the > couch_db_updater not functioning properly. I thought all the > "unlreased files" were related to views, and more specifically, view > compaction. Ie, its quite possible that calling couch_file:stop in the > proper place would've fixed this. So, my thought was perhaps with > Filipe's spotting this and adding the patch, it might fix the view > compaction leaking file descriptors issue. > > HTH, > Paul Davis > > On Sat, Sep 25, 2010 at 11:47 AM, Robert Dionne > <[email protected]> wrote: >> >> >> >> On Sep 25, 2010, at 11:15 AM, Randall Leeds wrote: >> >>> On Sat, Sep 25, 2010 at 17:07, Robert Dionne >>> <[email protected]> wrote: >>>> couch_file has a close function which presumably does the right thing, but >>>> it's only called from couch_db_update:terminate >>>> >>> >>> It just shuts down the process. >> >> right, I'm just wondering how couch_db_update:terminate is ever called? Does >> it receive an EXIT message? >> >> >>> The question on the table is whether >>> that will close the raw file opened by the process as well. Stephen, >>> can you reproduce the issue with .couch files if you set max_open_dbs >>> really low (like 2) and repeatedly access three or four databases? If >>> not, then I suspect it's a ref counting issue with the view index and >>> not directly related to couch_file at all. >>> >>> -Randall >> >>
