> > Here is an updated patch. It now use a filter sandbox instead of > patching the function and it fixes whitespaces.
Why a separate function to init the filter_sandbox? It can be done at the end of the existing init_sandbox() function (perhaps renaming it to init_sandboxes). I would rename Filter.filter_view to Filter.view_filter or to Filter.map_filter (doing the same in src/couchdb/couch_query_servers.erl for naming consistency). 4) is still there (the debugging ?LOG_INFO line). Also, this patch should only contain the changes necessary to implement the new feature. While all the whitespace and indentation fixes (to comply with the wiki rules) are a welcome plus, they should come in a separate patch imo. good work regards, -- Filipe David Manana, [email protected], [email protected] "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men."
