Haha. On 3 Dec 2010, at 11:09, Robert Dionne wrote:
> > > > On Dec 3, 2010, at 5:13 AM, Noah Slater (JIRA) wrote: > >> >> [ >> https://issues.apache.org/jira/browse/COUCHDB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966471#action_12966471 >> ] >> >> Noah Slater commented on COUCHDB-975: >> ------------------------------------- >> >> I'd be more comfortable with: >> >> -version="`${ERL} -version 2>&1 | ${SED} "s/[[^0-9]]/ /g"`" >> +version="`${ERL} -version 2>&1 | ${SED} 's/[[^0-9]]/ /g'`" > > wow, my new glasses work! I can see the diff between these two lines :) > > >> >> Can you confirm this would work? >> >>> non-portable sh in configure.ac (breaks on Solaris) >>> --------------------------------------------------- >>> >>> Key: COUCHDB-975 >>> URL: https://issues.apache.org/jira/browse/COUCHDB-975 >>> Project: CouchDB >>> Issue Type: Bug >>> Components: Build System >>> Affects Versions: 0.8, 0.8.1, 0.9, 0.9.1, 0.9.2, 0.10, 0.10.1, 0.10.2, >>> 0.11, 0.11.1, 0.11.2, 1.0, 1.0.1 >>> Environment: OpenSolaris (will affect other Solaris versions, too) >>> SunOS osol-x86 5.11 snv_111b i86pc i386 i86pc Solaris >>> Reporter: Timothy Smith >>> Priority: Minor >>> Original Estimate: 0.08h >>> Remaining Estimate: 0.08h >>> >>> Get this when running configure: >>> ... >>> checking for erl... /export/home/tim/c/build-couchdb/build/bin/erl >>> ./configure[12123]: : cannot execute [Is a directory] >>> /opt/csw/bin/gsed: -e expression #1, char 9: unterminated `s' command >>> ./configure[12123]: /g: not found [No such file or directory] >>> ./configure[12125]: test: argument expected >>> ./configure[12129]: test: argument expected >>> ./configure[12133]: test: argument expected >>> checking for erlc... /export/home/tim/c/build-couchdb/build/bin/erlc >>> ... >>> A patch to fix it is: >>> commit 6b018d087ba8ddaf3789e106ade9b74488de5136 >>> Author: Timothy Smith <[email protected]> >>> Date: Thu Dec 2 23:13:10 2010 -0700 >>> Fix syntax error with /bin/sh on Solaris >>> >>> The RHS of an assignment is implicitly quoted in Bourne shell. Not >>> all shells (in particular, not /bin/sh in Solaris) can handle nested >>> double-quotes like foo="`bar "baz"`", and it's always safe to not >>> use the outer set. >>> diff --git a/configure.ac b/configure.ac >>> index c609a08..73ea9fe 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -243,7 +243,7 @@ fi >>> >>> erlang_version_error="The installed Erlang version is less than 5.6.5 >>> (R12B05). >>> >>> -version="`${ERL} -version 2>&1 | ${SED} "s/[[^0-9]]/ /g"`" >>> +version=`${ERL} -version 2>&1 | ${SED} "s/[[^0-9]]/ /g"` >>> >>> if test `echo $version | ${AWK} "{print \\$1}"` -lt 5; then >>> AC_MSG_ERROR([$erlang_version_error]) >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >
