[ 
https://issues.apache.org/jira/browse/COUCHDB-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979126#action_12979126
 ] 

Filipe Manana commented on COUCHDB-1011:
----------------------------------------

Hi Nikolai,

thanks, good work.

Just by looking at the diff:

1) You have a typo in the error messages: "Invavalid" 

2) Here:

+ if ( resp.history == null || resp._local_id) {

I think just checking for "resp.ok === true" is enough and covers success for 
all types of replications (continuous, by doc IDs, filtered)


I'll try out the patch next week.

regards


> Add replication by doc-IDs to Futon
> -----------------------------------
>
>                 Key: COUCHDB-1011
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1011
>             Project: CouchDB
>          Issue Type: New Feature
>          Components: Futon
>            Reporter: Filipe Manana
>            Priority: Minor
>         Attachments: COUCHDB-1011.patch
>
>
> Currently Futon doesn't allow users to trigger replications by doc-IDs.
> This would be a nice addition and a good starting point for new contributors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to