[ 
https://issues.apache.org/jira/browse/COUCHDB-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Joseph Davis updated COUCHDB-1042:
---------------------------------------

    Attachment: curl_as_soft_dep.patch

Just a slightly modified patch that agrees on most bits.

Only big changes are that http.c puts the "no curl support" version at the top 
so that people that just open the file will realize straight away why the whole 
file is enclosed in a #ifndef instead of being required to scroll all the way 
to the bottom.

Second bit cleans up the command line parsing in couchjs (binary) by doing a 
couple extra steps in couchjs shell script. I'm not as enamored with this bit 
so if you think your way is better feel free to reject that part. Thought he 
http.c ifdef switch I would like to keep.

> make libcurl a soft (optional) dependency
> -----------------------------------------
>
>                 Key: COUCHDB-1042
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1042
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.0.1
>            Reporter: Randall Leeds
>            Priority: Minor
>             Fix For: 1.2, 2.0
>
>         Attachments: 0001-make-cURL-an-optional-dependency.patch, 
> curl_as_soft_dep.patch
>
>
> CouchDB currently uses libcurl only in couchjs to expose HTTP client 
> functions to the JavaScript environment. This functionality is used by the 
> JavaScript unit tests. For idempotent views it is discouraged to perform I/O 
> in a view function. Therefore, I propose that libcurl be made an optional 
> dependency, automatically detected at build time, and a flag added to couchjs 
> so it can be explicitly enabled in the unit tests (but disabled, by default, 
> for the query server).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to