[
https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990805#comment-12990805
]
Randall Leeds commented on COUCHDB-1024:
----------------------------------------
I think it is incompatible, but not for the reason I said.
get_rep_endpoint converts from #httpdb{} to {remote, Url, Headers} or {remote,
Url, Headers, OAuthList}.
But the latest code you just linked adds default headers:
https://github.com/fdmanana/couchdb/blob/trunk_new_replicator/src/couchdb/couch_replicator_utils.erl#L206
which means we get {remote, Url, [{"Accept", "application/json"},
{"User-Agent", "CouchDB/" ++ couch_server:get_version()}]}
compare to
https://github.com/apache/couchdb/blob/1.0.x/src/couchdb/couch_rep.erl#L524
{remote, Url, []}
Also. If we use default headers there that include a different user agent it
means we *guarantee* we break checkpoints on every version upgrade. No?
> New replicator implementation
> -----------------------------
>
> Key: COUCHDB-1024
> URL: https://issues.apache.org/jira/browse/COUCHDB-1024
> Project: CouchDB
> Issue Type: Improvement
> Components: Replication
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%[email protected]%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details
> since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:
> https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as
> well.
> Also take note that some pull replications of databases with attachments
> created by prior CouchDB releases (including 1.0.1, but excluding the soon to
> be released 1.0.2) may hang forever. This is fixed by applying the patch for
> COUCHDB-1022 to the source server.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
