[
https://issues.apache.org/jira/browse/COUCHDB-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104516#comment-13104516
]
Adam Kocoloski commented on COUCHDB-1278:
-----------------------------------------
Hi Jan, I took a look at https://github.com/janl/couchdb/commit/614091. I'm
not sure I understand how the error_logger process is involved. Your clients
are writing to the disk_log directly, but you've got a couch_access_log
gen_event hanging on the error_logger event manager. That event handler
listens for couch_access events and logs them to stdout, but I don't see any
couch_access events being generated. You're also making the error_logger
process subscribe to disk_log notifications, and removing the couch_access_log
handler if you get any (expecting that the event_sup thinger will restart it).
Looking over Filipe's recent changes to couch_log I can see that most of my
comments apply there as well. Perhaps he can shed some light on the design
here.
> Add Apache httpd-style common log access logging.
> -------------------------------------------------
>
> Key: COUCHDB-1278
> URL: https://issues.apache.org/jira/browse/COUCHDB-1278
> Project: CouchDB
> Issue Type: New Feature
> Reporter: Jan Lehnardt
>
> This module introduces a new log file couch_access.log in the spirit of
> Apache httpd's access.log.
> The log format is specified here:
> http://en.wikipedia.org/wiki/Common_Log_Format
> The module defaults to the more commonly used `extended` format,
> but can be configured to use the standard log format as well.
> This is a new module rather than an extension to the couch_log
> module to allow easy addition. Ideally, this will be a plugin in the future.
> A note for chunked responses, the response body length reported is
> "chunked" rather than the number of bytes. The case is unspecified
> in the format description. Maybe the fix is keeping track of bytes
> sent in a chunked response, but I didn't want to make the first stab
> at this more complicated that it has to be. I'm happy to adjust.
> See the full diff here:
>
> https://github.com/janl/couchdb/commit/614091e49380b3afab3c34ff65e6d87623059b8b
> I'm not proposing this to be added to 1.1.x, but if anybody wants it, there's
> a patch here:
>
> https://github.com/janl/couchdb/commit/508af053257c074ec37c9bd658479cc21b8d20d4
> (The only difference is the specification of the couch_access_log module on
> startup, as that
> moved from couch_server_sup.erl to couch_primary_services.erl)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
