[
https://issues.apache.org/jira/browse/COUCHDB-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118957#comment-13118957
]
Paul Joseph Davis commented on COUCHDB-893:
-------------------------------------------
Get rid of couchjs_dev. Its never used. And if it is, we should fix that
instead.
What's this change doing there?
-AC_INIT([LOCAL_PACKAGE_NAME], [LOCAL_VERSION], [], [LOCAL_PACKAGE_TARNAME])
+AC_INIT([LOCAL_PACKAGE_NAME], [LOCAL_VERSION], [LOCAL_BUG_URI],
+ [LOCAL_PACKAGE_TARNAME])
This is odd:
+ $(MAKE) -f Makefile couchjs;
Is it really necessary to have a sub-process make build couchjs when the build
target already depends on it? That seems wrong.
I'd tab in the continuation lines in help.h string literals. Like you said its
gnarly, but its not like we'll be looking at it that much.
Your macro formatting annoys me.
#define couch_usage(basename) \
fprintf( \
stdout, \
USAGE_TEMPLATE, \
basename, \
basename, \
PACKAGE_NAME, \
basename, \
PACKAGE_BUGREPORT \
)
Not that my slashes will line up with the comment formatting.
Left over debugging?
+ fprintf(stdout,
+ "Script name:\t%s\n"
+ "Stack size:\t%d\n"
+ "HTTP enabled:\t%d\n",
+ args->script_name,
+ args->stack_size,
+ args->use_http);
+
Not sure about libgen here. Normally I'd be all for basename of argv[0] but I
tend to wonder if this is gonna brea on Windows. I'd go ahead and leave it
though. If it doesn't work on windows we can just #ifdef hardcode it there.
> Error: os_process_error {exit_status,0} when rendering view on 17 mb doc,
> couchapp and data attached
> -------------------------------------------------------------------------------------------------------
>
> Key: COUCHDB-893
> URL: https://issues.apache.org/jira/browse/COUCHDB-893
> Project: CouchDB
> Issue Type: Bug
> Affects Versions: 1.0.1
> Environment: I repeated this on windows and linux (64 bit)
> Reporter: Michael Schneider
> Assignee: Randall Leeds
> Fix For: 1.1.1, 1.2
>
> Attachments: 0001-improve-argument-parsing-in-couchjs.patch,
> bugdoc.tar.gz
>
>
> I have a large set of documents that I harvesting data from. All docs < 9mb
> render fine (with doc size increased)
> Attached is a simple couchapp and one doc.
> To reproduce, untar and:
> reproduce
> 1) untar file
> 2) cd bugdoc/couchapp/bugreport
> 3) couchapp push bugreport
> 4) cd bugdoc
> 5) python submitbadjson.py
> open url
> http://127.0.0.1:5984/_utils/database.html?bugreport/_design/bugreport/_view/buggy
> You should see a popup
> "(Error: os_process_error
> {exit_status,0})
> "
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
