[
https://issues.apache.org/jira/browse/COUCHDB-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119768#comment-13119768
]
Benjamin Young commented on COUCHDB-1285:
-----------------------------------------
Should we consider splitting this ticket? One for vendor object stuff and one
for modules?
This modules approach seems great as it's tied to more useful features than
just version reporting, but it also greatly extends the meaning of this
ticket's title. :)
Great work, Randall.
> Allow configuration of vendor and module version in the welcome message
> -----------------------------------------------------------------------
>
> Key: COUCHDB-1285
> URL: https://issues.apache.org/jira/browse/COUCHDB-1285
> Project: CouchDB
> Issue Type: Improvement
> Reporter: Jan Lehnardt
> Attachments: vendor_and_modules.patch,
> vendor_and_modules_objects.patch
>
>
> The patch below allows to configure vendor and module version information
> into the GET / welcome message.
> E.g.
> [vendor]
> name = refuge
> version = 2.0.0
>
> [modules]
> geocouch = 1.2.1
> would produce:
>
> {"couchdb":"Welcome","version":"1.2.0","refuge":"2.0.0","modules":{"geocouch":"1.2.1"}}
> --
> --- a/src/couchdb/couch_httpd_misc_handlers.erl
> +++ b/src/couchdb/couch_httpd_misc_handlers.erl
> @@ -30,9 +30,23 @@
> % httpd global handlers
>
> handle_welcome_req(#httpd{method='GET'}=Req, WelcomeMessage) ->
> + Vendor = case couch_config:get("vendor") of
> + [] -> [];
> + Vendor1 -> [{
> + proplists:get_value("name", Vendor1),
> + ?l2b(proplists:get_value("version", Vendor1))
> + }]
> + end,
> +
> + Modules = lists:map(fun({Key, Value}) ->
> + {Key, ?l2b(Value)}
> + end, couch_config:get("modules")),
> +
> send_json(Req, {[
> {couchdb, WelcomeMessage},
> - {version, list_to_binary(couch_server:get_version())}
> + {version, list_to_binary(couch_server:get_version())}]
> + ++ Vendor
> + ++ [{modules, {Modules}}
> ]});
> handle_welcome_req(Req, _) ->
> send_method_not_allowed(Req, "GET,HEAD").
> --
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
