On Fri, Oct 21, 2011 at 1:26 PM, Dave Cottlehuber <[email protected]> wrote: > On 21 October 2011 19:14, Paul Davis <[email protected]> wrote: >> On Fri, Oct 21, 2011 at 8:20 AM, Dave Cottlehuber <[email protected]> wrote: >>> On Thursday, 20 October 2011, Robert Newson <[email protected]> wrote: >>>> This is the second release vote for Apache CouchDB 1.1.1 >>>> >>>> Changes since round 1; >>>> >>>> * Fix object sealing with SpiderMonkey 1.7.0 >>>> * Update CHANGES/NEWS to reflect COUCHDB-1129 >>>> * Fix JavaScript CLI test runner >>>> >>>> We encourage the whole community to download and test these release >>>> artifacts so that any critical issues can be resolved before the release >>>> is made. Everyone is free to vote on this release. Please report your >>>> results and vote to this thread. >>>> >>>> We are voting on the following release artifacts: >>>> >>>> http://people.apache.org/~rnewson/dist/1.1.1/ >>>> >>>> Instructions for validating the release tarball can be found here: >>>> >>>> http://people.apache.org/~rnewson/dist/ >>>> >>>> Instructions for testing the build artefacts can be found here: >>>> >>>> http://wiki.apache.org/couchdb/Test_procedure >>>> >>>> These artifacts have been built from the 1.1.1 tag in Git: >>>> >>>> apache-couchdb-1.1.1.tar.gz >>>> apache-couchdb-1.1.1.tar.gz.md5 >>>> apache-couchdb-1.1.1.tar.gz.asc >>>> apache-couchdb-1.1.1.tar.gz.sha >>>> >>>> Test ALL the things. >>>> >>>> B. >>>> >>> >>> -1 sorry from windows land. >>> >>> #1 libgen.h doesn't exist in our rarified air here. is this only needed to >>> support basename in couchjs? I'm not sure what the right fix is here, as >>> most BSDs seem to also require cdefs.h which also doesn't exist. >>> >> >> Windows bites again. It only exists for basename, so we should just >> hardcode that to couchjs. >> >>> couch@sendai /relax/couch_git/src/couchdb/priv >>> $ make >>> source='couch_js/util.c' object='couchjs-util.o' libtool=no \ >>> DEPDIR=.deps depmode=none /bin/sh ../../../build-aux/depcomp \ >>> cc.sh -DHAVE_CONFIG_H -I. -I../../.. >>> -L/relax/tracemonkey-57a6ad20eae9/js/src/dist/lib -L/usr/local/lib >>> -L/opt/local/lib -I/relax/otp_src_R14B03/release/win32/usr/include >>> -I/relax/tracemonkey-57a6ad20eae9/js/src/dist/include -DXP_WIN -g -Wall >>> -Werror -D_BSD_SOURCE -I/relax/curl/include -DCURL_STATICLIB -O2 -c -o >>> couchjs-util.o `test -f 'couch_js/util.c' || echo './'`couch_js/util.c >>> c:\cygwin\relax\couch_git\src\couchdb\priv\couch_js\help.h(16) : fatal error >>> C1083: Cannot open include file: 'libgen.h': No such file or directory >>> make: *** [couchjs-util.o] Error 2 >>> >>> #2 NEWS ICU update should be 4.4 not 4.2. >>> >>> diff --git i/NEWS w/NEWS >>> index e62289e..d440ad0 100644 >>> --- i/NEWS >>> +++ w/NEWS >>> @@ -24,7 +24,7 @@ Version 1.1.1 >>> * Fix missing revisions in _changes?style=all_docs. >>> * Improve handling of compaction at max_dbs_open limit. >>> * JSONP responses now send "text/javascript" for Content-Type. >>> -* Link to ICU 4.2 on Windows. >>> +* Link to ICU 4.4 on Windows. >>> * Permit forward slashes in path to update functions. >>> * Reap couchjs processes that hit reduce_overflow error. >>> * Status code can be specified in update handlers. >>> >>> A+ >>> Dave >>> >> >> Will fix. >> > > awesome - thanks Paul. > > +1 for hardcoding it. Is it possisible at least to hardcode it to the > target filename generated in the Makefile - "softcoding" perhaps? > > Either way, the actual file is "couchjs.exe". > > A+ > Dave >
We can just brute force it with a Makefile conditional.
