Randall, which test exactly was failing in changes.js? I've never had such failure locally. If it's due to browser caching, it would be a good idea to add a test to test/etap/073-changes.t
On Wed, Nov 9, 2011 at 10:07 AM, <[email protected]> wrote: > fix improper comparison on filtered changes > > Regression caught by the changes js test. > > > Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo > Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/6213d064 > Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/6213d064 > Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/6213d064 > > Branch: refs/heads/master > Commit: 6213d064ef2467be9e6673df0fa71ffa9821ba4a > Parents: 866769f > Author: Randall Leeds <[email protected]> > Authored: Wed Nov 9 01:16:36 2011 -0800 > Committer: Randall Leeds <[email protected]> > Committed: Wed Nov 9 01:40:56 2011 -0800 > > ---------------------------------------------------------------------- > src/couchdb/couch_changes.erl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/couchdb/blob/6213d064/src/couchdb/couch_changes.erl > ---------------------------------------------------------------------- > diff --git a/src/couchdb/couch_changes.erl b/src/couchdb/couch_changes.erl > index ab95481..267f3d7 100644 > --- a/src/couchdb/couch_changes.erl > +++ b/src/couchdb/couch_changes.erl > @@ -328,7 +328,7 @@ send_lookup_changes(FullDocInfos, StartSeq, Dir, Db, Fun, > Acc0) -> > end, > GreaterFun = case Dir of > fwd -> > - fun(A, B) -> A >= B end; > + fun(A, B) -> A > B end; > rev -> > fun(A, B) -> A =< B end > end, > > -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men."
