[ 
https://issues.apache.org/jira/browse/COUCHDB-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151246#comment-13151246
 ] 

Benoit Chesneau commented on COUCHDB-1323:
------------------------------------------

I've upgraded my branch with latest changes in replication. Following are my 
answers:

- couch_replicator.app is commited? Shouldn't be the case now.

- couch_replicator_manager is now registered . I'm not sure why we need to 
register others here. What would be the benefit. 

- About records, I'm not sure if it could be usable actually for other things. 
However, that is something we could change easily in another patch I think once 
we are sure it couldn't be used in another parts?

- nitpick, fixed. 

- I agree, more generally we could have such things in couch_core, for cache 
support as well imo.

Side points. I think we could benefit here by using a "simple_one_for_one" 
supervisor for replication tasks rather a "one_for_one" . So it would simplify 
the calll and termination handling imo. We are in a case where this kind of 
supervision works pretty well. In near future I really would like couchdb built 
as a full erlang release where couch core and others are applications booted on 
start. Lot of things would benefit from it.

                
> couch_replicator
> ----------------
>
>                 Key: COUCHDB-1323
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1323
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>    Affects Versions: 2.0, 1.3
>            Reporter: Benoit Chesneau
>              Labels: replication
>         Attachments: 
> 0001-move-couchdb-replication-to-a-standalone-application.patch, 
> 0001-move-couchdb-replication-to-a-standalone-application.patch, 
> 0001-move-couchdb-replication-to-a-standalone-application.patch, 
> 0001-move-couchdb-replication-to-a-standalone-application.patch
>
>
> patch to move couch replication modules in in a standalone couch_replicator 
> application. It's also available on my github:
> https://github.com/benoitc/couchdb/compare/master...couch_replicator

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to