[
https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155283#comment-13155283
]
Bob Dionne commented on COUCHDB-1289:
-------------------------------------
Filipe,
I've seen these guidelines. I think this code adheres to them. If it doesn't
I'll fix it. The "true" clause is aligned with the initial "Done" boolean. I
think this is acceptable. I know you and Adam think these should be under the
"If", similar to the "case", but there is many places in the couchdb code where
this is not true. I'll put it under the if since the's the way it is elsewhere
in this same file.
How about for case statements? Should the clauses line up under the "case"?
Cheers,
Bob
> heartbeats skipped when continuous changes feed filter function produces no
> results
> -----------------------------------------------------------------------------------
>
> Key: COUCHDB-1289
> URL: https://issues.apache.org/jira/browse/COUCHDB-1289
> Project: CouchDB
> Issue Type: Bug
> Components: Database Core
> Reporter: Bob Dionne
> Assignee: Bob Dionne
> Priority: Minor
> Attachments:
> 0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch
>
>
> if the changes feed has a filter function that produces no results,
> db_updated messages will still be sent and the heartbeat timeout will never
> be reached.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
