I can review on Saturday if no one gets to it. Noah, that's how I read it, these are fixes in 1.2 that aren't on master, so they'd be regressions without Randall's merge.
Sent from the ocean floor On 11 Oct 2012, at 10:28, Noah Slater <[email protected]> wrote: > These were fixes that landed on the 1.2.x branch, but were never ported to > master? > > I assume that's what you're proposing to do now? > > On Thu, Oct 11, 2012 at 12:24 AM, Randall Leeds > <[email protected]>wrote: > >> Hey devs, >> >> Before 1.2 shipped, I made some hotfixes on the 1.2.x branch (I know, >> I'm sorry). >> >> I finally went through them. I posted a branch called 'hotfixes1.2' to >> the asf repo. >> >> Here are all the changes that I had made, along with the commit on the >> hotfix branch that corresponds. >> >> >> >> These are related to improving logging during file operation failures: >> >> 04c4a1041de06e8e39983cf9616c8baf9d889106 >> ede9482fc3c9e629572ab1376d88f4499c4c8beb >> cd238b42d1333cece5ab899c35c3b83ada8d448a >> af9e1c883ca4accb209cccc7ac9d26efa4daf1fd >> ba8fa86890087650a02a8ebaaea2537468999472 >> >> ... it is encompassed by 6e3f17a85b3de5d3c5ff2865bc58a1b9a6a47fab >> >> >> This one logs all 500 errors at the httpd level: >> >> 6887953432e9ccdef4bb8785b782fc53f6e61602 >> >> ... it is exactly 205ccb07114107e6daf7a156764c751e2f9f1571 >> >> >> >> This one updated NEWS & CHANGES for the above: >> >> 25e079117218b52c18d51dca0810b974ec80ff8a >> >> ... And I took the liberty of including the below as well >> and put all the notice in a1cc138689973f5f6e5ff68aa9204dbe1ddb179c >> >> >> This one fixed COUCHDB-1445: >> >> 94e72e7fcc66f6740a3ec517a1bccf2cfa024cf7 >> >> ... is exactly f79591d73c7fa02f2938875bceac691703938f81 except I >> left out the test because it was strange to begin with. >> >> >> This one is no longer necessary, as the new 1.3 indexer code never had >> this bug: >> >> a38f59d1752ec611f0edc26e8f641a36b52f0c67 >> >> >> Okay to merge? Thanks for looking. >> > > > > -- > NS
